Align the signature of the method for multiloading natural id entities #9955
Conversation
…s with the one for normal entity multiloading Signed-off-by: Jan Schatteman <[email protected]>
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
| * by their simple (basic/embedded) type. | ||
| */ | ||
| <K> List<E> multiLoad(K[] naturalIds, MultiNaturalIdLoadOptions options, SharedSessionContractImplementor session); | ||
| <K> List<E> multiLoad(K[] naturalIds, MultiNaturalIdLoadOptions options, EventSource eventSource); |
There was a problem hiding this comment.
Am I still allowed to do this at this point in time @gavinking @sebersole @yrodiere ?
There was a problem hiding this comment.
This would prevent that method being called from a StatelessSession.
There was a problem hiding this comment.
This would prevent that method being called from a
StatelessSession.
fair point i guess?
This doesn't seem to be a concern for the normal multiple id loading though?
There was a problem hiding this comment.
@jrenaat if you look in StatelessSessionImpl, you'll see how I had to hack in multiple id loading with a criteria query, I guess precisely because MultiIdEntityLoader.load() requires an EventSource. We should fix that!
There was a problem hiding this comment.
@jrenaat if you look in
StatelessSessionImpl, you'll see how I had to hack in multiple id loading with a criteria query, I guess precisely becauseMultiIdEntityLoader.load()requires anEventSource. We should fix that!
Well, we certainly can if, as I asked, we can still modify the signature of the implied methods at this late point in the release path of v7 ... ?
|
Closing this as it's superseded by #9959 |
2 participants
with the one for normal entity multiloading
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.